Model validation for FS models#165
Merged
Merged
Conversation
Contributor
|
@aliazzzdat thanks for all the changes! Looks like some tests are failing, can we fix those and also do a full instantiation of Stacks to confirm everything is still working as expected? Version changes can be tricky, and want to make sure we don't break anything |
Contributor
Author
Contributor
Author
aliazzzdat
force-pushed
the
dev_validation
branch
from
July 23, 2024 21:14
1084e49 to
87efc6c
Compare
arpitjasa-db
approved these changes
Jul 25, 2024
arpitjasa-db
left a comment
Contributor
There was a problem hiding this comment.
Thanks for all the changes @aliazzzdat !
This was referenced Jul 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.






FS models cannot predict as pyfunc models yet (issue #70), thus we can't use MLflow Evaluate with FS models.
However, MLflow Evaluate can take a function instead of a pyfunc model_uri.
This means we can call an FS model in the function and use this function in the Evaluate method.
Although this is a good solution, we still cannot enable baseline comparison, as we need to provide a model_uri of a pyfunc model (so this means it's not possible to compare a new FS model with a baseline FS model).