Skip to content

Lakehouse monitoring integration#156

Merged
arpitjasa-db merged 22 commits into
databricks:mainfrom
s-udhaya:lakehouse-monitoring-integration
Jun 5, 2024
Merged

Lakehouse monitoring integration#156
arpitjasa-db merged 22 commits into
databricks:mainfrom
s-udhaya:lakehouse-monitoring-integration

Conversation

@s-udhaya

@s-udhaya s-udhaya commented May 3, 2024

Copy link
Copy Markdown
Contributor

This PR integrates lakehouse monitoring, with automatic retraining component into mlops-stack.

@arpitjasa-db arpitjasa-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments, but thanks for doing this @s-udhaya !

resolve the `TODOs` in the ModelValidation task of [model-workflow-resource.yml](./model-workflow-resource.yml).


### Setting up model monitoring

@arpitjasa-db arpitjasa-db May 7, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Setting up model monitoring
### Setting up Lakehouse monitoring

Change elsewhere too please to match our branding

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand we are still discussing on this internally. I will update this when we finalize the unified naming convention

- Minor readme changes
- Use dafault assets_dir path for monitoring
@s-udhaya
s-udhaya force-pushed the lakehouse-monitoring-integration branch 5 times, most recently from ff13cdd to 37bf41b Compare May 16, 2024 10:12
- Accept inference table name from CLI
- Merge monitoring related resources into a single file
- Parametrize the metric and validation threshold
@s-udhaya
s-udhaya force-pushed the lakehouse-monitoring-integration branch from 37bf41b to a7c882b Compare May 16, 2024 10:20
@arpitjasa-db
arpitjasa-db requested a review from aravind-segu June 4, 2024 02:27

@aravind-segu aravind-segu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Overall. Thank you for working on this. Left some comments. Can we also do an E2E test on this?

@arpitjasa-db
arpitjasa-db requested a review from aravind-segu June 4, 2024 19:14
@arpitjasa-db
arpitjasa-db merged commit 4306c6b into databricks:main Jun 5, 2024
@RegaCaska

Copy link
Copy Markdown

Where did you find documentation for creating monitors through asset bundles as demonstrated in this PR? I see no documentation in the databricks asset bundle configurations reference, nor the Lakehouse Monitoring page Is this due to the feature being in private preview?

@arpitjasa-db

Copy link
Copy Markdown
Contributor

Where did you find documentation for creating monitors through asset bundles as demonstrated in this PR? I see no documentation in the databricks asset bundle configurations reference, nor the Lakehouse Monitoring page Is this due to the feature being in private preview?

@RegaCaska the DAB docs might still be generating, you can ask in the CLI GitHub, but if you'd like you can use the Terraform or SDK docs to configure it in DABs since it uses the same structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants