Fix direct-engine genie_spaces apitype drift#5554
Merged
Merged
Conversation
genie_spaces (#5282) was mapped to dashboards.GenieSpace, but #5484 refreshed cli.json without re-running generate-direct. Regenerating flips the field-overlap matcher to dashboards.GenieUpdateSpaceRequest, which drops the output-only etag ignore_remote_changes behavior: GenieSpace.etag is OUTPUT_ONLY, whereas on GenieUpdateSpaceRequest it is a caller-supplied optimistic-concurrency token. Pin genie_spaces to dashboards.GenieSpace via the apitypes.yml override to keep the etag behavior, and refresh the doc artifacts that had also gone stale. Co-authored-by: Isaac
pietern
changed the title
genie_spaces apitype drift
janniklasrose
approved these changes
Jun 11, 2026
denik
approved these changes
Jun 11, 2026
Collaborator
|
Commit: 7cf178c
24 interesting tests: 15 SKIP, 7 KNOWN, 2 flaky
Top 31 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 58288ad
444 interesting tests: 393 MISS, 32 FAIL, 11 KNOWN, 4 flaky, 2 PANIC, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codegen gate from #5484 surfaced that
bundle/direct/dresources/*.generated.ymlwas never regenerated aftergenie_spaceswas added in #5282. Regenerating flips the field-overlap matcher fromdashboards.GenieSpacetodashboards.GenieUpdateSpaceRequest(it tie-breaks onGenieSpace's one extra field,space_id), which drops the output-onlyetagignore_remote_changesbehavior —GenieSpace.etagisOUTPUT_ONLY, while onGenieUpdateSpaceRequestit's a caller-supplied concurrency token.Fix: pin
genie_spaces: dashboards.GenieSpacevia theapitypes.ymloverride (same pattern aspostgres_projects).The docs
last_updatedate stamps are inherent non-reproducible drift that's out of scope to fix here.This pull request and its description were written by Isaac.