volumes/uppercase-name: add bundle destroy to prevent resource leak#5544
Merged
Conversation
Test added in #5531 never cleaned up MySCHEMA/MyVOLUME, causing every subsequent run to find them pre-existing and skip the POST calls, breaking the golden diff. Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Replace hardcoded MySCHEMA/MyVOLUME with MySCHEMA_$UNIQUE_NAME via envsubst so parallel runs on the same workspace don't step on each other. Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
pietern
approved these changes
Jun 11, 2026
Collaborator
|
Commit: 67f9695
22 interesting tests: 15 SKIP, 4 flaky, 3 RECOVERED
Top 30 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test added in #5531 never cleaned up
MySCHEMA/MyVOLUME, so the first run leaked them into the sharedmaincatalog. Every subsequent run found them pre-existing, skipped the POST calls, and failed the golden diff in all 4 ucws workspaces.Fix: add a
cleanup()trap that destroys the bundle on exit and removesout.requests.txtso the destroy requests don't show up as unexpected output.