acceptance: capture testing patterns from #5414 and auto-scope to test files#5422
Merged
Conversation
… EnvMatrix scoping Four idioms surfaced in PR #5414 review that weren't captured in the acceptance-test guide: - Limit `EnvMatrix.DATABRICKS_BUNDLE_ENGINE` when the test inspects engine-specific state shape (resources.json vs terraform.tfstate). - Prefer `gron.py | grep <field>` over inline `jq` for single-value lookups — the gron output line includes the JSON path, so the test log is self-explanatory. - Don't pass `--keep` to print_requests.py if a later call follows; the second call re-reads the buffer and double-prints. - Use `LOG.<name>` for cleanup-noise stderr that should show up only under `go test -v` (not dropped with `2>/dev/null`). Each rule has a GOOD / BAD example and points at existing tests that already follow the pattern. Co-authored-by: Isaac
Collaborator
|
Commit: dc8ed68
22 interesting tests: 15 SKIP, 7 KNOWN
Top 24 slowest tests (at least 2 minutes):
|
…rule Tighten the gron-over-jq, print_requests --keep, and LOG.<name> rules from multi-block GOOD/BAD examples to one-liners. Drop the EnvMatrix engine-scoping rule per maintainer feedback. Co-authored-by: Isaac
Adds path globs so the rules auto-load when Claude reads test files, matching how .agent/rules/dresources.md auto-loads under bundle/direct/dresources. Co-authored-by: Isaac
…e and cleanup stderr The dominant real-world pattern in acceptance/bundle/invariant/* is `&> LOG.deploy` paired with `contains.py '!panic'` to keep noisy non-deterministic output out of `output.txt` while still asserting invariants. Cover that as the primary case, with `2>>LOG.<name>` for cleanup-step stderr as the secondary case. Co-authored-by: Isaac
pietern
changed the title
denik
approved these changes
Jun 8, 2026
janniklasrose
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three acceptance-test idioms surfaced in #5414 review that weren't captured in
.agent/rules/testing.md:gron.py | grepoverjqfor single-value lookups.--keeptoprint_requests.pyif a later call follows.LOG.<name>—&> LOG.deploy+contains.py '!panic', or2>>LOG.<name>for cleanup stderr.Added
paths:frontmatter so the rules auto-load when Claude reads test files.This pull request and its description were written by Isaac.