Skip to content

[Python] Fix missing compute.Kind#3717

Merged
kanterov merged 1 commit into
mainfrom
fix-compute-kind
Oct 6, 2025
Merged

[Python] Fix missing compute.Kind#3717
kanterov merged 1 commit into
mainfrom
fix-compute-kind

Conversation

@kanterov

@kanterov kanterov commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Changes

Fix missing compute.Kind. There is a single documented value that applies a behaviour different from the absent value.

Add an enum annotation because it's missing in the OpenAPI spec.

Why

Fixes #3622

Tests

Looking at the diff for the generated code

@kanterov kanterov temporarily deployed to test-trigger-is October 3, 2025 13:54 — with GitHub Actions Inactive
@kanterov kanterov marked this pull request as ready for review October 3, 2025 13:54
@eng-dev-ecosystem-bot

eng-dev-ecosystem-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Run: 18224296011

Env ✅​pass 🔄​flaky 🙈​skip
✅​ aws linux 320 537
✅​ aws windows 321 536
✅​ aws-ucws linux 436 433
✅​ aws-ucws windows 437 432
✅​ azure linux 320 536
✅​ azure windows 321 535
✅​ azure-ucws linux 436 432
🔄​ azure-ucws windows 434 3 431
✅​ gcp linux 319 538
✅​ gcp windows 320 537
Test Name azure-ucws windows
TestAccept 🔄​flaky
TestAccept/bundle/templates/default-python/combinations/classic 🔄​flaky
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=no/NBOOK=no/PY=yes 🔄​flaky

@kanterov kanterov added this pull request to the merge queue Oct 6, 2025
Merged via the queue into main with commit ee1b500 Oct 6, 2025
19 checks passed
@kanterov kanterov deleted the fix-compute-kind branch October 6, 2025 07:54
denik pushed a commit that referenced this pull request May 20, 2026
## Changes
Fix missing `compute.Kind`. There is a single documented value that
applies a behaviour different from the absent value.

Add an enum annotation because it's missing in the OpenAPI spec.

## Why
Fixes #3622

## Tests
Looking at the diff for the generated code
pietern added a commit that referenced this pull request Jun 11, 2026
- names: title() now treats digits as non-separators (strings.Title
  semantics), so a digit-then-letter name like ai21labs_api_key derives
  Ai21labsApiKey, matching genkit and the SDK spelling. names_test.go pins
  the divergent classes (digit-then-letter, uppercase-acronym runs).
- model: Resolve() returns an error on duplicate service ids and unresolved
  parent / subservice / request-body references instead of silently rendering
  wrong output; the contract test also asserts no two services render to the
  same file.
- schema: drop the manual compute.Kind enum override (workaround from #3717);
  annotations_openapi.yml now carries the enum itself, so the override
  produced a duplicated CLASSIC_PREVIEW in jsonschema.json (+ for-docs).
- Taskfile: fingerprint generate-annotations (run: once) so `task generate`
  runs it once instead of three times; drop fingerprinting on the cli.json
  refresh task (the producer builds from universe HEAD, which no source
  fingerprint captures) and rename it generate-cli-json -> generate-clijson.
- changelog: NEXT_CHANGELOG.md entry for the DEVELOPMENT-stage enum/model
  removals from the released databricks-bundles package.
- comments/docs: document the clusters/events template special-cases, the
  LRO IsEmptyResponse fold, the intentional 0644 file mode, and .gitattributes
  ownership in generate-clijson; refresh stale generate-genkit references
  (AGENTS.md, agent rules, task descs, .gitignore) and the stale stored-casing
  claims in the names.go/model.go headers.

cmd/**, .gitattributes and the schema artifacts regenerate byte-identically
apart from the intended CLASSIC_PREVIEW dedupe.

Co-authored-by: Isaac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The kind field is missing from the ClusterSpec class

3 participants