Update OCM shares to last version of CS3APIs#3646
Merged
Merged
Conversation
…les with initial content and empty folders used by config files
gmgigi96
requested review from
a team,
glpatcern,
labkode and
wkloucek
as code owners
February 8, 2023 10:58
gmgigi96
marked this pull request as draft
February 8, 2023 11:02
gmgigi96
changed the title
Member
Author
|
@michielbdejong can you review? This is touching even the |
gmgigi96
marked this pull request as ready for review
February 8, 2023 17:53
glpatcern
reviewed
Feb 15, 2023
glpatcern
approved these changes
Feb 15, 2023
glpatcern
left a comment
glpatcern
left a comment
Member
There was a problem hiding this comment.
OK, let's go ahead with this large change that already includes several unit tests, but we need to test in QA now.
The transfer (or datatx) OCM shares where also refactored and will need some testing as well in the context of ScienceMesh (cc @redblom).
All OCM-related APIs are much clearer now, and a CLI is also available, which eases further developments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the OCM share implementation after the changes in cs3org/cs3apis#199, cs3org/OCM-API#54 and cs3org/OCM-API#57.
In particular:
ocmcoreandocmshareprovider, simplifying the single drivers, now just repositories, and implemented common logic at provider level.WebDAVaccess method for an OCM share (WebappandTransferlater in an other PR)ocm-share-get <id>andocm-share-get-received <id>to get the information of a single OCM shareThe
sharedSecretreturned with the WebDAV protocol is still with owner permissions on the home folder that created the share. Will follow up an other PR with a proper OCM scoped token.