Skip to content

CI: Update language versions - #111

Merged
amotl merged 10 commits into
mainfrom
amo/modernize
Nov 1, 2023
Merged

CI: Update language versions#111
amotl merged 10 commits into
mainfrom
amo/modernize

Conversation

@amotl

@amotl amotl commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

About

Bump a few language versions on CI, where possible.

  • Java 11 vs. 17
  • PHP 8.3
  • Python 3.12
  • Ruby 3.2

/cc @hammerhead, @hlcianfagna, @karynzv, @WalBeh

amotl added 9 commits October 30, 2023 19:48
aiohttp/_websocket.c:3042:53: error: ‘PyLongObject’ {aka ‘struct _longobject’} has no member named ‘ob_digit’
[...]

ERROR: Could not build wheels for aiohttp, which is required to install pyproject.toml-based projects
@amotl
amotl requested review from matriv and seut October 31, 2023 16:23
@amotl
amotl marked this pull request as ready for review October 31, 2023 16:29

@matriv matriv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left comments about java version.

Comment thread .github/workflows/testcontainers-java.yml Outdated
Comment thread .github/workflows/test-java-jooq.yml Outdated
Comment thread .github/workflows/test-java-jdbc.yml Outdated
@amotl
amotl requested a review from matriv November 1, 2023 10:53
@amotl
amotl merged commit a425f91 into main Nov 1, 2023
@amotl
amotl deleted the amo/modernize branch November 1, 2023 11:08
os: [ "ubuntu-latest" ]
cratedb-version: [ "nightly" ]
os: [ 'ubuntu-latest' ]
java-version: [ '17', '21' ]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: why not adding 11 here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants