[ub] a few more fixes#7888
Merged
Merged
Conversation
hsutter
approved these changes
May 24, 2025
shafik
approved these changes
May 28, 2025
shafik
left a comment
shafik
left a comment
There was a problem hiding this comment.
LGTM besides the comments I left.
I may do a run over the wording again.
Member
|
@timuraudio , ping. |
Author
|
I now applied all the changes suggested here! Are we good now? |
shafik
reviewed
Jun 11, 2025
shafik
left a comment
shafik
left a comment
There was a problem hiding this comment.
Thank you for the fixes, hopefully Jens is happy too.
jensmaurer
pushed a commit
that referenced
this pull request
Jul 26, 2025
jensmaurer
pushed a commit
that referenced
this pull request
Jul 26, 2025
jensmaurer
pushed a commit
that referenced
this pull request
Jul 26, 2025
jensmaurer
pushed a commit
that referenced
this pull request
Jan 12, 2026
notadragon
pushed a commit
to notadragon/cplusplus_draft
that referenced
this pull request
Apr 16, 2026
notadragon
pushed a commit
to notadragon/cplusplus_draft
that referenced
this pull request
May 1, 2026
notadragon
pushed a commit
to notadragon/cplusplus_draft
that referenced
this pull request
May 7, 2026
jensmaurer
pushed a commit
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR breaks up some
\ubdefentries in the UB annex into multiple, more granular entries, for those cases of UB where there is value in distinguishing them. This PR makes the list of UB in theub-ifndrbranch identical to the list of UB provided in Appendix A of P3100R2.