Do not record streaming measurement for quotes#4593
Conversation
|
Claude finished @jmg-duarte's task in 1m 43s —— View job PR Review: Do not record streaming measurement for quotes
The change is clean and does what it says. The One thing worth considering (posted inline): the metric decision is now coupled to the archiving path rather than directly to quote-vs-auction, so disabling archiving would silently drop the auction metric as well. Minor and likely fine in practice. Nothing blocking. LGTM. |
There was a problem hiding this comment.
Code Review
This pull request updates the default log filter to include observe::http_body=debug in both shared.rs and arguments.rs. Additionally, it refactors the streaming logic in crates/driver/src/infra/solver/streaming/mod.rs by introducing an optional metrics parameter to stream_into. This allows the caller to conditionally record auction overhead metrics, specifically disabling them for quotes while keeping them enabled for proper auctions. I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
MartinquaXD
left a comment
There was a problem hiding this comment.
I think there is 1 more metric that would be super nice to have.
Feel free to merge as is if you don't want to increase the scope of this PR.
| pub struct Measurements { | ||
| /// Wall-clock serialization cost, isolated from the time spent blocked | ||
| /// writing to the sinks (solver transfer + gzip). | ||
| pub serialize: Duration, |
There was a problem hiding this comment.
Could you please also record the total time and measure that for each solver individually?
There was a problem hiding this comment.
Done, please take a look and let me know if it is what you were looking for
There was a problem hiding this comment.
Yeah, that's exactly what I had in mind. This will be very helpful to help individual solvers resolve bottlenecks.
Description
With the new streaming measurements we started recording quotes too, this skews the metrics, the PR fixes it.
It also brings back the http_body logging that was lost when moved to the observe crate.
Changes
How to test
Grafana