hardening 051726#9
Merged
Merged
Conversation
rajithaeyee
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Secureflag to session cookies (conditional on TLS orX-Forwarded-Proto: https)HttpOnlyflag to session cookies to prevent JavaScript accessReadHeaderTimeout: 30sto mitigate slowloris-style header attacksIdleTimeout: 120sto reclaim idle keep-alive connectionsDetails
Cookie
Secureflag is set dynamically based onr.TLS != nil || strings.EqualFold(r.Header.Get("X-Forwarded-Proto"), "https"). This ensures cookies are marked Secure when served over HTTPS (direct or behind a TLS-terminating proxy) while preserving local development over plain HTTP.ReadHeaderTimeoutandIdleTimeoutare the two safe timeouts for a server that handles streaming responses and websocket connections.ReadTimeoutandWriteTimeoutare intentionally not set to avoid breaking long-lived connections.