Tolerate invalid cni cache for DelNetwork - #1171
Merged
squeed merged 2 commits intoOct 15, 2025
Merged
Conversation
Adapt fix for DelNetworkList to DelNetwork and update test. Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
scpeters
force-pushed
the
invalidcache_delnetwork
branch
from
October 1, 2025 06:54
c1a440b to
36b1672
Compare
squeed
approved these changes
Oct 1, 2025
squeed
requested changes
Oct 1, 2025
squeed
left a comment
squeed
left a comment
Member
There was a problem hiding this comment.
Looks like tests are failing; can you take a look?
Expect no error to have occurred when cached result cannot be converted. Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Contributor
Author
trying again in a30dcc7 |
Contributor
Author
can you approve the workflow to run again? |
squeed
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt the fix for DelNetworkList from #1072 to DelNetwork and update test.