SPEC: Clarify some language around DEL and prevResult - #1156
Merged
Conversation
Signed-off-by: Benjamin Leggett <benjamin@edera.io>
bleggett
force-pushed
the
bleggett/clarify-del
branch
from
April 9, 2025 22:07
2d24781 to
7f701df
Compare
bleggett
changed the title
DEL and prevResultDEL and prevResult
squeed
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I note that
libcniuses best-effort forprevResultloading - that is, ifprevResultcannot be found or is empty, each plugin is still invoked for a DEL operation, just without aprevResult.This wasn't super-clear to me reading the spec, though it is implied elsewhere, so this attempts to make it more obvious.