Skip to content

docs: fix typo and missing import in tools.md - #4917

Merged
ChengyuZhu6 merged 1 commit into
containerd:mainfrom
opjt:docs/chore
May 25, 2026
Merged

docs: fix typo and missing import in tools.md#4917
ChengyuZhu6 merged 1 commit into
containerd:mainfrom
opjt:docs/chore

Conversation

@opjt

@opjt opjt commented May 19, 2026

Copy link
Copy Markdown
Contributor

Fix a typo and missing tig import in docs/testing/tools.md.

  • Code sample uses mytest instead of myTest (variable name mismatch — myTest is what's actually declared).
  • Several code samples reference tig.T in their function signatures without importing
    "github.com/containerd/nerdctl/mod/tigron/tig".

Signed-off-by: Park jungtae <jtpark1957@gmail.com>
Comment thread docs/testing/tools.md
mytest.Command = test.Command("info")
myTest.Command = test.Command("info")
// Verify the command exits with 0, and stdout contains the word `Kernel`
myTest.Expected = test.Expects(0, nil, expect.Contains("Kernel"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some other changes if you like to do like there are constants in Tigron framework it self for these exit codes and so on

@ChengyuZhu6 ChengyuZhu6 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChengyuZhu6
ChengyuZhu6 merged commit 688cd27 into containerd:main May 25, 2026
9 checks passed
@ChengyuZhu6 ChengyuZhu6 added this to the v2.3.2 milestone May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants