Refactor compose_run_linux_test - #4845
Merged
AkihiroSuda merged 1 commit intoJun 1, 2026
Merged
Conversation
sathiraumesh
marked this pull request as draft
April 11, 2026 11:54
46 tasks
sathiraumesh
marked this pull request as ready for review
April 18, 2026 07:48
sathiraumesh
force-pushed
the
refactor_compose_run_linux_test_4613
branch
2 times, most recently
from
April 18, 2026 07:55
1c62fbd to
83f48b8
Compare
Contributor
Author
|
@AkihiroSuda this is up for review |
Member
|
HI, @sathiraumesh Thanks for creating this PR. It looks like the test you refactored is failing. Could you please check it?
|
Contributor
Author
|
sure @haytok ill have a look |
AkihiroSuda
marked this pull request as draft
May 14, 2026 17:41
Member
|
Marking as a draft due to the CI failure. |
sathiraumesh
force-pushed
the
refactor_compose_run_linux_test_4613
branch
3 times, most recently
from
May 22, 2026 08:37
7aa3be4 to
326f008
Compare
sathiraumesh
marked this pull request as ready for review
May 22, 2026 09:10
Contributor
Author
|
@AkihiroSuda its ready for review. I only migrated the non flaky tests. |
Contributor
Author
|
@AkihiroSuda a kind reminder to review this |
haytok
reviewed
May 30, 2026
Migrates the non-flaky compose run tests to nerdtest.Setup(): - TestComposeRunWithEnv - TestComposeRunWithUser - TestComposeRunWithArgs - TestComposeRunWithEntrypoint - TestComposeRunWithLabel (uses nerdtest.InspectContainer) - TestComposeRunWithVolume (uses nerdtest.InspectContainer) Replaces the unbuffer(1) pty wrapper with cmd.WithPseudoTTY(), and uses expect.ExitCodeSuccess instead of literal 0 for exit codes. TestComposeRunWithServicePorts, TestComposeRunWithPublish, and TestComposePushAndPullWithCosignVerify are intentionally left on the legacy framework for now (flaky / complex). Signed-off-by: sathiraumesh <sathiraumesh@gmail.com>
sathiraumesh
force-pushed
the
refactor_compose_run_linux_test_4613
branch
from
May 30, 2026 18:34
326f008 to
80cf9f8
Compare
Member
|
Contributor
Author
I don't think its because of the changes from this PR. |
AkihiroSuda
reviewed
Jul 9, 2026
| } | ||
|
|
||
| func TestComposeRunWithServicePorts(t *testing.T) { | ||
| base := testutil.NewBase(t) |
Member
There was a problem hiding this comment.
Some tests were not updated?
Contributor
Author
There was a problem hiding this comment.
yes I mentioned them specificaly in the decription since they are kined of very flaky @AkihiroSuda
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compose_run_linux_test.gofrom legacytestutil.NewBasetonerdtest.Setup()/ tigron frameworkNot included
TestComposePushAndPullWithCosignVerifyremains on legacy harness — blocked ontestregistryrequiring*testutil.Base, A seperate PR would be better of thisTestComposeRunWithServicePortsremains legacy due to the flakynessTestComposeRunWithPublishremains legacy due to the flakynesss