feat: add GuardStepUp node type to node-type-registry#1265
Merged
Conversation
Introduces the 'guard' category with GuardStepUp — a BEFORE trigger that calls require_step_up() to enforce recent password/MFA verification before DML. Supports compound conditions (AND/OR/NOT), watch_fields, and simple condition_field/condition_value leaf conditions. Mirrors constructive-db PR #1541.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
guardcategory to the node-type-registry withGuardStepUp— a BEFORE trigger node that enforcesrequire_step_up()(recent password/MFA verification) before allowing DML operations.Uses the existing
conditionDefs/conditionPropertiesfromconditions/for compound AND/OR/NOT support,watch_fields, and simple leaf conditions.Added
'guard'tocategoryOrderingenerate-types.tssoGuardStepUpParamsinterface is emitted during codegen.Mirrors the generator implementation in constructive-db #1541.
Link to Devin session: https://app.devin.ai/sessions/05f55404de8b435db075244b6edb4006
Requested by: @pyramation