Prevent initial scroll jump in NestedDraggableFlatlist#514
Open
ersefuril wants to merge 1 commit into
Open
Conversation
maroparo
reviewed
Dec 14, 2023
| () => { | ||
| return outerScrollOffset.value; | ||
| }, | ||
| (cur, prev) => { |
There was a problem hiding this comment.
Second parameter here doesn't seem to be used, and can be safely removed.
maroparo
approved these changes
Dec 14, 2023
maroparo
left a comment
maroparo
left a comment
There was a problem hiding this comment.
For what its worth, I approve the change. Seems to be working! 🚀
|
Will this PR be merged? I'm having the same issue and don't want to use |
|
@ersefuril Your solution doesn't work on my side. |
|
Any chance this is going to be ironed out soon? I definitely see the bug but I haven't tried patching this in yet. I found that as a workaround you can set activationDistance={0}, but this has the unhappy consequence of making nested lists unscrollable unless you drag on a non-list-item element. |
|
Doesnt work on my end. Does anyone else know the fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a small glitch when you try to drag n drop an item after performing an initial scroll.
This seems to occurs only in
NestedDraggableFlatList.The outer scroll position is not updated after doing a scroll, which causes a "jump".
It should fix this issue : #509