Skip to content

Separate out Unix and Windows non emscripten builds ci - #404

Merged
mcbarton merged 1 commit into
compiler-research:mainfrom
mcbarton:separate-Windows-build-non-emscripten-ci
Dec 20, 2024
Merged

mcbarton merged 1 commit into
compiler-research:mainfrom
mcbarton:separate-Windows-build-non-emscripten-ci

Conversation

@mcbarton

@mcbarton mcbarton commented Dec 19, 2024

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

This PR will separate out the Windows jobs from the Ubuntu and MacOS jobs in the non emscripten ci, to allow it be easier maintained and updated.

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Requires documentation updates

Testing

Please describe the test(s) that you added and ran to verify your changes.

Checklist

  • I have read the contribution guide recently

@codecov

codecov Bot commented Dec 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.87%. Comparing base (b810c6e) to head (8dfde1f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files           9        9           
  Lines        3533     3533           
=======================================
  Hits         2504     2504           
  Misses       1029     1029           

@vgvassilev vgvassilev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mcbarton
mcbarton merged commit 1323443 into compiler-research:main Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants