Remove hardcoding of CMAKE_PREFIX_PATH wasm build - #292
Merged
vgvassilev merged 1 commit intoMay 19, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 54.31% 54.31%
=======================================
Files 8 8
Lines 2957 2957
=======================================
Hits 1606 1606
Misses 1351 1351 |
mcbarton
force-pushed
the
Remove-hardcoded-path-wasm-ci
branch
from
May 18, 2024 18:58
ea6bf86 to
c2503f7
Compare
Collaborator
Author
|
@vgvassilev can this PR be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason CMAKE_PREFIX_PATH was hardcoded in the wasm builds. This has been corrected to be dependent on an environment variable.