feat: add Config\Optimize - #8605
Merged
Merged
Conversation
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
feat-add-config-optimize
branch
from
March 7, 2024 07:43
f739169 to
5ceaf06
Compare
This was referenced Mar 7, 2024
|
👋 Hi, @kenjis! |
kenjis
force-pushed
the
feat-add-config-optimize
branch
from
March 18, 2024 01:54
5ceaf06 to
cf15ad0
Compare
and move code from index.php to Boot class.
This setting is for Web Page Caching, not for Cache service.
The Cache Config class that extends BaseConfig is very slow to instantiate.. See codeigniter4#8558 (comment)
kenjis
force-pushed
the
feat-add-config-optimize
branch
from
March 26, 2024 21:20
cf15ad0 to
0e81024
Compare
kenjis
marked this pull request as ready for review
March 26, 2024 21:27
michalsn
approved these changes
Mar 27, 2024
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
I like this idea. It is much easier to manage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs #8604Description
Config\Optimize::$configCacheEnabledConfig\Optimize::$locatorCacheEnabledConfig\Optimizedoes not extendBaseConfigintentionally.Because simple plain small class is very fast to instantiate. See #8558 (comment)
Checklist: