fix: change getFile() function of \CodeIgniter\Events\Events to static. - #7046
Merged
Merged
Conversation
kenjis
added
the
bug
Member
|
By the way, can you remove |
Contributor
Author
|
Ok, I'll handle this. |
kenjis
reviewed
Jan 4, 2023
kenjis
approved these changes
Jan 5, 2023
kenjis
changed the title
getFile() function of \CodeIgniter\Events\Events to static.getFile() function of \CodeIgniter\Events\Events to static.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7045
But I have a question is does the
$this->managerstill be needed in the test case oftest\system\Events\EventsTest.phpfile?Because all the functions in Event class are static, does it mean that this class no longer needs to be constructed?
Checklist: