Skip to content

fix: required PHP extentions - #6897

Merged
kenjis merged 4 commits into
codeigniter4:developfrom
kenjis:fix-required-php-ext
Nov 24, 2022
Merged

fix: required PHP extentions#6897
kenjis merged 4 commits into
codeigniter4:developfrom
kenjis:fix-required-php-ext

Conversation

@kenjis

@kenjis kenjis commented Nov 23, 2022

Copy link
Copy Markdown
Member

Description

  • update the docs
  • remove curl and xml from required PHP extension check in CodeIgniter

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only labels Nov 23, 2022
@cijagani

Copy link
Copy Markdown
Contributor

@kenjis

kenjis commented Nov 23, 2022

Copy link
Copy Markdown
Member Author

@cijagani Yes, ext-curl is required if you use CURLRequest.
But if you don't use CURLRequest, you don't need it.

@cijagani

Copy link
Copy Markdown
Contributor

we should keep curl-extenstion as required in doc. cz of if someone use CURLRequest and curl extenstion is not installed then it will throw exeptions.

@kenjis

kenjis commented Nov 23, 2022

Copy link
Copy Markdown
Member Author

@MGatner

MGatner commented Nov 23, 2022

Copy link
Copy Markdown
Member

We should consider moving CURLRequest to a dedicated library with the proper requirement.

@kenjis
kenjis merged commit 30fe0c2 into codeigniter4:develop Nov 24, 2022
@kenjis
kenjis deleted the fix-required-php-ext branch November 24, 2022 05:16
@MGatner MGatner added the next major version? Read this for a relevant v5 idea label Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them documentation Pull requests for documentation only next major version? Read this for a relevant v5 idea

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants