Skip to content

Fix coverage merge warning - #6885

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
paulbalandan:fix-coverage-warning
Nov 23, 2022
Merged

Fix coverage merge warning#6885
samsonasik merged 1 commit into
codeigniter4:developfrom
paulbalandan:fix-coverage-warning

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Attempt to fix file_put_contents warning when merging cov files.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the github_actions Pull requests that update Github_actions code label Nov 19, 2022
Comment thread .github/workflows/test-phpunit.yml Outdated
@paulbalandan
paulbalandan force-pushed the fix-coverage-warning branch 2 times, most recently from ea570e5 to 10216c1 Compare November 19, 2022 13:03
@paulbalandan paulbalandan changed the title Cache phpunit's static analysis coverage cache Upload phpunit's static analysis coverage cache Nov 19, 2022
@paulbalandan
paulbalandan force-pushed the fix-coverage-warning branch 2 times, most recently from 960cad5 to dca2df7 Compare November 19, 2022 13:49
@paulbalandan paulbalandan changed the title Upload phpunit's static analysis coverage cache Fix coverage merge warning Nov 19, 2022
kenjis
kenjis previously approved these changes Nov 20, 2022
@kenjis
kenjis dismissed their stale review November 20, 2022 02:37

I misunderstood it as a GitHub Action setup.

Comment thread phpunit.xml.dist
@samsonasik
samsonasik merged commit aaed696 into codeigniter4:develop Nov 23, 2022
@samsonasik

Copy link
Copy Markdown
Member

Thank you @paulbalandan

@paulbalandan
paulbalandan deleted the fix-coverage-warning branch November 23, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants