Fix: Controller Test withBody() - #6843
Merged
Merged
Conversation
MGatner
force-pushed
the
controller-test-with-body
branch
from
November 12, 2022 23:40
0b59a7a to
3f5e063
Compare
kenjis
approved these changes
Nov 13, 2022
kenjis
added
the
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ControllerTestTrait"with___" methods use local property references to apply their changes before execution. This doesn't work for$bodyhowever because it is a string and not passed by reference, so usingwithBody()has no effect.This PR moves the application of the body to the
execute()method so it is properly applied to the request prior to execution.Checklist: