Skip to content

fix: composer update might cause error "Failed to open directory" #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 4 commits into from
Nov 20, 2022
Merged

fix: composer update might cause error "Failed to open directory" #6833

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dba9f8
Exit function recursiveDelete if nothing to do
LeMyst Nov 8, 2022
65b4738
Update system/ComposerScripts.php
LeMyst Nov 11, 2022
970e533
Exit if the composer update cannot create the target directory
LeMyst Nov 12, 2022
204a76a
Update system/ComposerScripts.php
LeMyst Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions system/ComposerScripts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ public static function postUpdate()
private static function recursiveDelete(string $directory): void
{
if (! is_dir($directory)) {
Comment thread
kenjis marked this conversation as resolved.
echo sprintf('Cannot recursively delete "%s" as it does not exist.', $directory);
echo sprintf('Cannot recursively delete "%s" as it does not exist.', $directory) . PHP_EOL;

return;
}

/** @var SplFileInfo $file */
Expand Down Expand Up @@ -126,7 +128,11 @@ private static function recursiveMirror(string $originDir, string $targetDir): v
exit(1);
}

@mkdir($targetDir, 0755, true);
if (! @mkdir($targetDir, 0755, true)) {
echo sprintf('Cannot create the target directory: "%s"' . PHP_EOL, $targetDir);
Comment thread
LeMyst marked this conversation as resolved.
Outdated

exit(1);
}

$dirLen = strlen($originDir);

Expand Down