Skip to content

Refactor assertHeaderEmitted and assertHeaderNotEmitted - #6806

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:refactor-assert-headers
Nov 2, 2022
Merged

Refactor assertHeaderEmitted and assertHeaderNotEmitted#6806
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:refactor-assert-headers

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Reuse existing utility method

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Nov 1, 2022
Comment thread system/Test/CIUnitTestCase.php Outdated
@paulbalandan
paulbalandan force-pushed the refactor-assert-headers branch from 916fffa to 549e1ca Compare November 2, 2022 02:43

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice dedupe

@paulbalandan
paulbalandan merged commit 9dd92e0 into codeigniter4:develop Nov 2, 2022
@paulbalandan
paulbalandan deleted the refactor-assert-headers branch November 2, 2022 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants