Skip to content

fix: Call to undefined method CodeIgniter\HTTP\CLIRequest::getLocale() - #6442

Merged
MGatner merged 2 commits into
codeigniter4:developfrom
kenjis:fix-CLIRequest-getLocale-error
Aug 29, 2022
Merged

fix: Call to undefined method CodeIgniter\HTTP\CLIRequest::getLocale()#6442
MGatner merged 2 commits into
codeigniter4:developfrom
kenjis:fix-CLIRequest-getLocale-error

Conversation

@kenjis

@kenjis kenjis commented Aug 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description
Fixes #6377
Follow-up #6421

  • add CLIRequest::getLocale()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis added 2 commits August 29, 2022 08:04
@kenjis
test: fix incorrect assertions
5e7b4fe
@kenjis
fix: add missing CLIRequest::getLocale()
6aafff0 
Call to undefined method CodeIgniter\HTTP\CLIRequest::getLocale()
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Aug 28, 2022
@kenjis kenjis mentioned this pull request Aug 28, 2022
Closed
5 tasks
@MGatner
MGatner merged commit 31aab61 into codeigniter4:develop Aug 29, 2022
@kenjis
kenjis deleted the fix-CLIRequest-getLocale-error branch May 14, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Cant use route_to function in cli request

2 participants

@kenjis @MGatner