Skip to content

refactor: add test for DownloadResponse - #6375

Merged
samsonasik merged 4 commits into
codeigniter4:developfrom
kenjis:fix-CodeIgniterTest
Aug 14, 2022
Merged

refactor: add test for DownloadResponse#6375
samsonasik merged 4 commits into
codeigniter4:developfrom
kenjis:fix-CodeIgniterTest

Conversation

@kenjis

@kenjis kenjis commented Aug 13, 2022

Copy link
Copy Markdown
Member

Description
Follow-up #6361

  • add hack for testing in CodeIgniter.php
  • add test for DownloadResponse
  • fix tests with dynamic property

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code testing Pull requests that changes tests only labels Aug 13, 2022
@MGatner

MGatner commented Aug 13, 2022

Copy link
Copy Markdown
Member

Cool hack though 😎

@samsonasik
samsonasik merged commit cc8758b into codeigniter4:develop Aug 14, 2022
@samsonasik

Copy link
Copy Markdown
Member

Thank you @kenjis

@kenjis
kenjis deleted the fix-CodeIgniterTest branch August 14, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants