Skip to content

Change: PHPDoc return type in ControllerTestTrait methods - #6168

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
iRedds:fix/controller-test-trait
Jun 21, 2022
Merged

Change: PHPDoc return type in ControllerTestTrait methods#6168
samsonasik merged 1 commit into
codeigniter4:developfrom
iRedds:fix/controller-test-trait

Conversation

@iRedds

@iRedds iRedds commented Jun 21, 2022

Copy link
Copy Markdown
Collaborator

Description
Replacing the return type in the ControllerTestTrait methods in the docBlock section from mixed to $this.
This allows the IDE to use hints in the chain call.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis changed the title Change: return type in ControllerTestTrait methods Change: PHPDoc return type in ControllerTestTrait methods Jun 21, 2022
@samsonasik
samsonasik merged commit cac7bf3 into codeigniter4:develop Jun 21, 2022
@samsonasik

Copy link
Copy Markdown
Member

Thank you @iRedds

@iRedds
iRedds deleted the fix/controller-test-trait branch June 22, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants