Skip to content

fix: Model::_call() static analysis - #5970

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:fix-Model-static-analysis
May 8, 2022
Merged

fix: Model::_call() static analysis#5970
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:fix-Model-static-analysis

Conversation

@kenjis

@kenjis kenjis commented May 6, 2022

Copy link
Copy Markdown
Member

Description
Fixes #4509

  • remove @mixin BaseBuilder, add @method

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 6, 2022

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sad that dynamic extensions didn't work out (but grateful you tried it). This looks like an improvement, and it already allowed SA to detect a mistake!

@kenjis

kenjis commented May 7, 2022

Copy link
Copy Markdown
Member Author

It might be my misunderstanding that the dynamic extensions didn't work out.
But the true problem is not sure what methods really can be used.
I mean, it was later discovered that getCompiled*() could not be used after all.
The current implementation can call all Builder methods, but not sure if that will actually work well.

It would be better to add really usable methods to @method.

@kenjis
kenjis merged commit 496dece into codeigniter4:develop May 8, 2022
@kenjis
kenjis deleted the fix-Model-static-analysis branch May 8, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Model::_call() static analysis

2 participants