refactor: add strtolower() to Request::getMethod() - #5963
Merged
kenjis merged 2 commits intoMay 5, 2022
Merged
Conversation
The $upper functionality will be removed.
The $upper functionality will be removed.
paulbalandan
approved these changes
May 5, 2022
Collaborator
|
Why did you choose the strtolower function instead of the strtoupper function? |
Member
Author
|
I chose strtolower() or strtoupper() to fit the current implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes #5766
The
$upperfunctionality will be removed.Checklist: