Skip to content

feat: [Parser] add configs to change conditional delimiters - #5842

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:feat-parser-conditional-delimiter
Apr 2, 2022
Merged

feat: [Parser] add configs to change conditional delimiters#5842
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:feat-parser-conditional-delimiter

Conversation

@kenjis

@kenjis kenjis commented Mar 31, 2022

Copy link
Copy Markdown
Member

Description
Fixes #5831

  • add properties $leftConditionalDelimiter and $rightConditionalDelimiter
  • add method setConditionalDelimiters()

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them labels Mar 31, 2022

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An elegant solution. I'd like someone who actually uses the View Parser to review as well (if we have one available).

@kenjis
kenjis merged commit e075dbf into codeigniter4:develop Apr 2, 2022
@kenjis
kenjis deleted the feat-parser-conditional-delimiter branch April 2, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: View parser throws view exception with nested 'if' within javascript code

3 participants