Skip to content

fix: [Validation] valid_date ErrorException when the field is not sent #5804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenjis merged 2 commits into from
Mar 16, 2022
Merged

fix: [Validation] valid_date ErrorException when the field is not sent #5804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e954172
fix: ErrorException when the field is not sent
kenjis Mar 16, 2022
6bd3ee9
refactor: remove uneeded parentheses
kenjis Mar 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions system/Validation/FormatRules.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,10 @@ public function valid_url_strict(?string $str = null, ?string $validSchemes = nu
*/
public function valid_date(?string $str = null, ?string $format = null): bool
{
if ($str === null) {
return false;
}

if (empty($format)) {
return strtotime($str) !== false;
}
Expand Down
5 changes: 5 additions & 0 deletions tests/system/Validation/FormatRulesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1206,6 +1206,11 @@ public function testValidDate(?string $str, ?string $format, bool $expected): vo
public function validDateProvider(): Generator
{
yield from [
[
null,
'Y-m-d',
false,
],
[
'Sun',
'D',
Expand Down