Skip to content

fix: debug toolbar vars response headers includes request headers - #5701

Merged
samsonasik merged 4 commits into
codeigniter4:developfrom
zl59503020:patch-9
Feb 17, 2022
Merged

fix: debug toolbar vars response headers includes request headers#5701
samsonasik merged 4 commits into
codeigniter4:developfrom
zl59503020:patch-9

Conversation

@zl59503020

@zl59503020 zl59503020 commented Feb 16, 2022 •
edited by kenjis
Loading

Copy link
Copy Markdown
Contributor

update debug toolbar vars response header

Description
update debug toolbar vars response header no repeat request header

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis

kenjis commented Feb 17, 2022

Copy link
Copy Markdown
Member

@zl59503020 Can you fix the coding style?

@kenjis

kenjis commented Feb 17, 2022

Copy link
Copy Markdown
Member

Before:
Screenshot 2022-02-17 10 03 28

After:
Screenshot 2022-02-17 10 03 37

@zl59503020

zl59503020 commented Feb 17, 2022

Copy link
Copy Markdown
Contributor Author

@zl59503020你能修复编码风格吗？

ok

@kenjis

kenjis commented Feb 17, 2022

Copy link
Copy Markdown
Member

See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#php-style

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 17, 2022
@kenjis kenjis changed the title update debug toolbar vars response header fix: debug toolbar vars response headers includes request headers Feb 17, 2022
@samsonasik
samsonasik merged commit f8267cb into codeigniter4:develop Feb 17, 2022
@samsonasik

samsonasik commented Feb 17, 2022

Copy link
Copy Markdown
Member

Thank you @zl59503020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zl59503020 @kenjis @samsonasik