Skip to content

fix: DownloadResponse memory leak - #5623

Merged
samsonasik merged 2 commits into
codeigniter4:developfrom
kenjis:fix-download-memory-leak
Jan 29, 2022
Merged

fix: DownloadResponse memory leak#5623
samsonasik merged 2 commits into
codeigniter4:developfrom
kenjis:fix-download-memory-leak

Conversation

@kenjis

@kenjis kenjis commented Jan 27, 2022

Copy link
Copy Markdown
Member

Description
Fixes #5620

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jan 27, 2022
@samsonasik
samsonasik requested a review from MGatner January 27, 2022 01:42
@MGatner

MGatner commented Jan 27, 2022

Copy link
Copy Markdown
Member

I will try this on desktop.

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, and this fixes the issue on the test repo! Embarrassing how small that was for how long I've been dealing with this 😅

@samsonasik
samsonasik merged commit 25f60cc into codeigniter4:develop Jan 29, 2022
@samsonasik

Copy link
Copy Markdown
Member

Thank you @kenjis

@kenjis
kenjis deleted the fix-download-memory-leak branch January 30, 2022 00:54
@kenjis kenjis mentioned this pull request May 18, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: DownloadResponse Fails with Large Files

4 participants