BaseService - Use lowercase key in resetSingle

[najdanovicivan]

Since injectMock converts key to lowercase we need to use lowercase key as well in resetSingle method

Description
Fixes #5595

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Can you add test case to prove the code works?

Note, we expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works.
https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md#unit-testing

[najdanovicivan]

@kenjis test is added

[kenjis]

I think our convention is that a service name is all lower case.
This should be someservice.

[najdanovicivan]

I did not know about that convention but there is nothing limiting the user not to use any letter casing.

Function names in PHP are case insensitive so it will work with any case. And it make sense to me to use camel case for service names

[kenjis]

This must be lowercase.

CodeIgniter4/system/Config/Services.php

Line 180 in 812af1e

public static function curlrequest(array $options = [], ?ResponseInterface $response = null, ?App $config = null, bool $getShared = true)

[kenjis]

Thank you for adding a test!
I added some inline comments.

I think the added someService() should be removed,
because it is not necessary for the test.
Use an existing service.

[najdanovicivan]

Ok I made this very simple now. I though we should have some real case example with non lowercase name and that is the reason why I added someService()

But since there is a convention for lowercase in service method there is no need for that. We just need to make the method do to lowercase conversion to match how other methods in Service classes behave.

[kenjis]

Thank you!

As you say, a user may use camelCase,
but I think this test case is enough.

[MGatner]

Since serviceExists() uses lowercase only for method lookup I think all services must be lower unless the user is calling them directly from Config\Services.

This is a good catch and fix.