Validation: support placeholders for anything - #5545
Merged
paulbalandan merged 1 commit intoJan 15, 2022
Merged
Conversation
paulbalandan
force-pushed
the
fix-validation-placeholders
branch
from
January 5, 2022 14:52
34e33d0 to
c1974ee
Compare
Member
|
This method change should be safe, right? Since all extended classes will still have |
Member
Author
|
No, the parameter will no longer be contravariant since extending classes will now be typehinting a specific type (string) from the parent's type (this PR proposing as mixed). |
Member
|
In that case we will we need additions to the upgrade guide noting the BC. Since we have a |
Member
|
LGTM except documentation. |
paulbalandan
force-pushed
the
fix-validation-placeholders
branch
2 times, most recently
from
January 14, 2022 13:09
75ca70c to
ab8eadb
Compare
kenjis
reviewed
Jan 14, 2022
paulbalandan
force-pushed
the
fix-validation-placeholders
branch
from
January 15, 2022 09:47
ab8eadb to
84ac2ea
Compare
kenjis
approved these changes
Jan 15, 2022
Member
|
🥳 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supersedes and closes #3910
Fixes #3774
I tried cherry-picking @element-code 's commit but ended up with merge conflicts instead, so the original authorship was lost.
The breaking change with this is the signature change of
setRule.Checklist: