This repository was archived by the owner on May 20, 2026. It is now read-only.
[CM-1317] add rendering mode support - #60
Merged
Merged
Conversation
… disabled rules for file [UPDATE] add disable rule
SahilSainiYML
force-pushed
the
issue/CM-1317-AddReneringMode
branch
from
April 10, 2023 08:47
35a3773 to
786c0e4
Compare
[UPDATE] added // swiftlint:disable superfluous_disable_command
SahilSainiYML
force-pushed
the
issue/CM-1317-AddReneringMode
branch
from
April 10, 2023 09:30
205c363 to
88122bf
Compare
mpospese
suggested changes
Apr 10, 2023
mpospese
left a comment
mpospese
left a comment
Contributor
There was a problem hiding this comment.
This Issue is to modify SystemImage, not ImageAsset so you modified the wrong protocol. Also, see if you can simply delete the large_tuple rule to please SwiftLint.
SahilSainiYML
force-pushed
the
issue/CM-1317-AddReneringMode
branch
2 times, most recently
from
April 10, 2023 12:08
b5238fb to
c334375
Compare
mpospese
reviewed
Apr 10, 2023
SahilSainiYML
force-pushed
the
issue/CM-1317-AddReneringMode
branch
2 times, most recently
from
April 10, 2023 14:08
1f75eb1 to
1556c2a
Compare
mpospese
reviewed
Apr 10, 2023
SahilSainiYML
force-pushed
the
issue/CM-1317-AddReneringMode
branch
from
April 10, 2023 16:05
c0d490e to
85bbd08
Compare
mpospese
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Expanded the functionality of our system image loading protocol to include rendering mode. Now user can choose between the rendering mode to apply on the image(s).
Purpose
This will let users set the rendering mode on an entire group (enum) of images.
Fix #56
Scope
Updated
ImageAssetprotocol to supportstatic var renderingMode: UIImage.RenderingMode? { get }. Made modification inloadImage.Some swiftLint rules are updated in files.
📈 Coverage
Code
100%
Documentation
100%
