Skip to content

Fix regression in RDS validator - #2346

Merged
markpeek merged 1 commit into
mainfrom
bug2345
Dec 3, 2025
Merged

Fix regression in RDS validator#2346
markpeek merged 1 commit into
mainfrom
bug2345

Conversation

@markpeek

@markpeek markpeek commented Dec 3, 2025

Copy link
Copy Markdown
Member

@yamjoepobuda I think this is more explicit to fix the regression. Can you verify and approve?

@yamjoepobuda

yamjoepobuda commented Dec 3, 2025

Copy link
Copy Markdown

Updated the line and it ran without issue. However, looking at this it may need to be done for oracle as well?

14484-        if engine in ["mariadb", "mysql", "postgres"]:
14539-            min_storage_size = 400
14574-        elif engine in ["oracle"]:
14609-            min_storage_size = 200
14644-        elif engine.startswith("sqlserver"):
14689-            min_storage_size = 20
14723-            min_iops_to_allocated_storage_ratio = 0.5
14777-        else:
14791-            raise ValueError(
14821:                f"StorageType gp3 is not supported for engine " f"{engine}"
14897-            )

@yamjoepobuda yamjoepobuda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change is good as-is to resolve the reported issue, but oracle may have regressed as well.

@markpeek

markpeek commented Dec 3, 2025

Copy link
Copy Markdown
Member Author

Thank you for the review. Good catch on the oracle change. I pushed a new version and added tests as well for both of them. Can you take a look before a merge?

@yamjoepobuda yamjoepobuda left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you for looking into this quickly!

@markpeek
markpeek merged commit 9aeb4ae into main Dec 3, 2025
7 checks passed
@markpeek
markpeek deleted the bug2345 branch December 3, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants