Add new oracle-ee-cdb engine to the valid db engine on rds validator - #2335
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds support for the oracle-ee-cdb engine and modernizes the RDS engine validation by converting the valid engines list to a set and adding several new engine types. This update addresses issue #2333 by including the missing oracle-ee-cdb engine type.
- Added
oracle-ee-cdbengine to valid RDS engines - Converted
VALID_DB_ENGINESfrom tuple to set for better performance - Added additional engine types including DB2 and CDB variants
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
8be559a to
b1f59d6
Compare
|
troposphere [ update-rds-validate-engines][?][📦 v0.0.0][ v22.19.0][🐍 v3.11.11] Running pyright... ======================================= test session starts ======================================== tests/test_apigateway.py .. [ 0%] ======================================= 561 passed in 1.32s ======================================== |
|
Excellent. Thank you for the PR and additional cleanup. |
This is a new PR addressing comments from #2334 and should "fix" Issue #2333
Sorry for closing the old one and open a new ... but I wasn't able to fully do all operations on my work account, so I moved to my personal one.