-
Notifications
You must be signed in to change notification settings - Fork 80
fix: make hevy-mcp CLI start stdio server again #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| import { runServer } from "./index.js"; | ||
|
|
||
| void runServer().catch((error) => { | ||
| console.error("Fatal error in main():", error); | ||
| process.exit(1); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/cli.tsis TypeScript source but imports"./index.js", which bakes the emitted.jsextension into the source path. That’s brittle against future changes in build configuration (e.g., different extension, multiple output formats, or non-relative resolution) and makes this file behave differently undertsx/ts-nodevs compiled output. Since the rest of the codebase uses extension-less internal imports in TS (e.g.,"./utils/hevyClient.js"in tests is fine because it only runs under Node+ts-node/tsx test environment), this one stands out as a maintainability risk for the CLI entrypoint specifically.Using the module name without the extension (
"./index") keeps the TS source decoupled from a specific JS extension while still resolving correctly through tsup and Node’s ESM loader in the built output.Suggestion
Consider changing the import in
src/cli.tsto avoid hard-coding the.jsextension, so the TS source does not depend on the emitted filename details:This keeps the CLI entry resilient if you later tweak tsup output options (e.g., different extension or dual CJS/ESM builds). Reply with "@CharlieHelps yes please" if you'd like me to add a commit with this suggestion.