Fix acf bug - #15
Merged
Merged
Conversation
kjroelke
marked this pull request as ready for review
August 12, 2026 20:04
kjroelke
requested review from
blake-perkins-dev
and
a lite review from Copilot
and removed request for
Copilot
August 12, 2026 20:04
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the plugin/block versions and addresses an ACF Related Events edge case where mapped events can return null, while also adding a local tool to audit npm packages’ lifecycle scripts and risky patterns.
Changes:
- Filter out invalid (null) event entries before sorting/rendering related events (block render + REST route helper).
- Add an npm package audit helper script and ignore its
.tmp/output directory. - Bump project and block versions, update dependency lockfiles, and refresh changelogs/metadata.
Reviewed changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/audit-npm-script-package.sh | Adds a CLI helper to pack/extract an npm package and scan for risky patterns/lifecycle scripts. |
| src/blocks/acf-related-events/render.php | Filters mapped related-event entries prior to sorting/rendering. |
| src/blocks/acf-related-events/CHANGELOG.md | Introduces a block-level changelog documenting the null-filtering fix. |
| src/blocks/acf-related-events/block.json | Adds block version 1.0.1. |
| package.json | Bumps package version, fixes homepage URL typo, adds an npm script to run the audit tool, updates dev deps and allowScripts. |
| inc/routes/class-acf-rest-router.php | Filters mapped events before sorting/returning from REST router helper. |
| composer.lock | Updates PHPCS/WPCS-related dev tooling versions and lockfile hash. |
| composer.json | Bumps Composer package version to 2.7.1. |
| cno-plugin-cno-blocks.php | Bumps plugin header version and “Tested up to” value. |
| CHANGELOG.md | Adds v2.7.1 entry pointing to the ACF Related Events block changelog. |
| .gitignore | Ignores .tmp/ (used by the new audit tool output). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
blake-perkins-dev
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.