Improve the algorithm list on README - #509
Merged
Merged
Conversation
prabhatnagarajan
self-requested a review
July 17, 2019 09:32
muupan
changed the title
prabhatnagarajan
suggested changes
Jul 17, 2019
prabhatnagarajan
left a comment
prabhatnagarajan
left a comment
Contributor
There was a problem hiding this comment.
I checked the links. They're correct. Only two small comments.
Co-Authored-By: Prabhat Nagarajan <prabhat.nagarajan@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the algorithm list on README by adding links to papers and examples. The paper list is removed. You can check the new README here: https://github.com/chainer/chainerrl/tree/improve-algorithm-list
I removed
PGTbecause it does not follow any paper and I think it's not worth mentioning in README. I'm not sure if the technique list covers all the techniques worth mentioning, but we can add later.