Skip to content

Apply noisy_net_sigma parameter - #465

Merged
keisuke-nakata merged 2 commits into
chainer:masterfrom
keisuke-nakata:noisy-net-sigma
Jun 3, 2019
Merged

Apply noisy_net_sigma parameter#465
keisuke-nakata merged 2 commits into
chainer:masterfrom
keisuke-nakata:noisy-net-sigma

Conversation

@keisuke-nakata

Copy link
Copy Markdown
Member

The specified value for noisy_net_sigma was ignored when NoisyNet is enabled.

@toslunar toslunar self-assigned this Jun 3, 2019

@toslunar toslunar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix examples/atari/rainbow/train_rainbow.py, too?

@keisuke-nakata

Copy link
Copy Markdown
Member Author

I fixed examples/ale/train_dqn_batch_ale.py as well.
(examples/atari/rainbow/train_rainbow.py was already fixed at the first commit)

@toslunar toslunar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toslunar toslunar changed the title apply noisy_net_sigma parameter Apply noisy_net_sigma parameter Jun 3, 2019
@keisuke-nakata
keisuke-nakata merged commit f5509b9 into chainer:master Jun 3, 2019
@keisuke-nakata
keisuke-nakata deleted the noisy-net-sigma branch June 3, 2019 08:04
@muupan muupan mentioned this pull request Jun 3, 2019
@muupan muupan added this to the v0.7 milestone Jun 28, 2019
@muupan muupan added the bug label Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants