Skip to content

Add tests of IQN examples - #405

Merged
muupan merged 1 commit into
chainer:masterfrom
muupan:test-iqn-example
Feb 27, 2019
Merged

Add tests of IQN examples#405
muupan merged 1 commit into
chainer:masterfrom
muupan:test-iqn-example

Conversation

@muupan

@muupan muupan commented Feb 26, 2019

Copy link
Copy Markdown
Member

Tests of IQN examples were missing, so this PR adds them to test_examples.sh. Updated the examples to make them work with latest API.

@muupan muupan added this to the v0.6 milestone Feb 26, 2019
@muupan

muupan commented Feb 26, 2019

Copy link
Copy Markdown
Member Author

I confirmed that both ./test_examples.sh -1 and ./test_examples.sh 0 work.

@prabhatnagarajan prabhatnagarajan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;

@muupan muupan added the test label Feb 26, 2019
@muupan
muupan merged commit 94a0d41 into chainer:master Feb 27, 2019
@muupan
muupan deleted the test-iqn-example branch February 27, 2019 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants