Skip to content

Fix TestTrainAgentAsync - #363

Merged
muupan merged 1 commit into
chainer:masterfrom
toslunar:test-async-lock
Dec 6, 2018
Merged

Fix TestTrainAgentAsync#363
muupan merged 1 commit into
chainer:masterfrom
toslunar:test-async-lock

Conversation

@toslunar

@toslunar toslunar commented Dec 5, 2018

Copy link
Copy Markdown
Member
  • https://travis-ci.org/chainer/chainerrl/jobs/463226829

            # A hook receives (env, agent, step)
            for i, call in enumerate(hook.call_args_list):
                args, kwargs = call
                self.assertTrue(any(args[0] == env for env in envs))
                self.assertEqual(args[1], agent)
                # step starts with 1
    >           self.assertEqual(args[2], i + 1)
    E           AssertionError: 5 != 4
    
  • https://travis-ci.org/chainer/chainerrl/jobs/463226831

            if self.num_envs == 1:
                self.assertEqual(hook.call_count, steps)
            elif self.num_envs > 1:
    >           self.assertGreater(hook.call_count, steps)
    E           AssertionError: 3 not greater than 5
    

@toslunar
toslunar requested a review from muupan December 5, 2018 03:02

@muupan muupan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@muupan
muupan merged commit e89ca4e into chainer:master Dec 6, 2018
@toslunar
toslunar deleted the test-async-lock branch December 6, 2018 05:01
@muupan muupan added this to the v0.6 milestone Feb 26, 2019
@muupan muupan added the test label Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants