Use gym and atari wrappers instead of chainerrl.envs.ale - #253
Conversation
The model learned for Breakout with both FireResetEnv and EpisodicLifeEnv would not generalize to the env without EpisodicLifeEnv.
which is used in http://arxiv.org/abs/1509.06461
|
atari_wrappers.py in openai/baselines use |
|
Below are elapsed time (sec) on 10000 steps of chainerrl.envs.ale.ALE and new atari_wrappers (https://github.com/muupan/chainerrl/blob/atari-wrappers-speed/examples/ale/check_atari_wrappers_speed.py). |
|
Since DeepMind papers use 5 min (= 5 * 60 * 60 // 4 steps) to evaluation episodes (see https://arxiv.org/abs/1507.04296 etc), I applied it to all the examples. It seems it affect performance, especially on BeamRider. |
|
It seems to me that the wrappers assume |
Don't you think stating that only `*NoFrameskip-v4' is supported is sufficient? The rule to convert 'pong' to 'PongNoFrameskip-v4' may not be simple, e.g., underscore and version upgrade. It would be helpful to list up possible env names in the error message if the user specifies invalid one. |
toslunar
left a comment
There was a problem hiding this comment.
LGTM except that hacking 1.1 warns gym.undo_logger_setup()
Add noqa to `gym.undo_logger_setup()`






















Resolves #251