Skip to content

Add docstring to ALE and fix seed range - #234

Merged
muupan merged 3 commits into
chainer:masterfrom
muupan:ale-fix-seed2
Feb 15, 2018
Merged

Add docstring to ALE and fix seed range#234
muupan merged 3 commits into
chainer:masterfrom
muupan:ale-fix-seed2

Conversation

@muupan

@muupan muupan commented Feb 13, 2018

Copy link
Copy Markdown
Member

No description provided.

@toslunar toslunar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except a line

Comment thread chainerrl/envs/ale.py Outdated
game (str): Name of a game. You can get the complete list of supported
games by calling atari_py.list_games().
seed (int or None): If set to an int, it is used as a random seed for
the ALE. It must be in [0, 2 ** 16). If set to None, numpy's random

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[0, 2 ** 31)

@muupan

muupan commented Feb 15, 2018

Copy link
Copy Markdown
Member Author

Thank you, I fixed it.

@toslunar toslunar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muupan
muupan merged commit 60518af into chainer:master Feb 15, 2018
@muupan
muupan deleted the ale-fix-seed2 branch February 15, 2018 04:20
@muupan muupan added this to the v0.4 milestone Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants