Add gpus argument for chainerrl.misc.set_random_seed - #207
Merged
Conversation
Member
Author
|
The test passed with cupy and a single gpu. I also manually checked with two gpus: |
toslunar
approved these changes
Dec 22, 2017
toslunar
left a comment
Member
There was a problem hiding this comment.
LGTM.
Let me leave a survey on seeds.
random.seed(with the current defaultversion=2) uses all the bits of int.numpy.random.seedaccepts int in [0, 2 ** 32).cupy.random.seedaccepts int that can be casted safely touint64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpusargument tochainerrl.misc.set_random_seedto set a seed ofcupy.randomas well asrandomandnumpy.random.