Skip to content

Warn about negative exit code of child processes #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toslunar merged 3 commits into from
Dec 6, 2017
Merged

Warn about negative exit code of child processes #194

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f18a594
Warn about negative exit code of child processes
muupan Dec 1, 2017
4e1a88d
Improve the warning message for nonzero status
muupan Dec 6, 2017
8757bbb
Add tests for exit code warnings
muupan Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions chainerrl/misc/async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
standard_library.install_aliases()

import multiprocessing as mp
import warnings

import chainer
import numpy as np
Expand Down Expand Up @@ -132,6 +133,10 @@ def set_seed_and_run(process_idx, run_func):

for p in processes:
p.join()
if p.exitcode < 0:
warnings.warn(
"Process {}'s exit code was not zero but {}".format(

@toslunar toslunar Dec 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to know the process_idx.
How about "Process #{} (pid={}) exited with nonzero status {}".format(i, p.pid, p.exitcode)?

p.pid, p.exitcode))


def as_shared_objects(obj):
Expand Down